add tests for new aws functions

Author: tonerdo

modules/bash-commons/src/aws-wrapper.sh

@@ -179,7 +179,6 @@ function aws_wrapper_get_ips_with_tag {
 
   local instances
   instances=$(aws_get_instances_with_tag "$tag_key" "$tag_value" "$aws_region")
-  assert_not_empty_or_null "$instances" "Get info about Instances with tag $tag_key set to $tag_value"
 
   local readonly ip_param=$([[ "$use_public_ips" == "true" ]] && echo "PublicIpAddress" || echo "PrivateIpAddress")
   echo "$instances" | jq -r ".Reservations[].Instances[].$ip_param"

test/aws-cli.bats

@@ -121,4 +121,32 @@ END_HEREDOC
   local num_instances
   num_instances=$(echo "$output" | jq -r '.Reservations | length')
   assert_greater_than "$num_instances" 0
-}
+}
+
+@test "aws_get_instances_with_tag empty" {
+  run aws_get_instances_with_tag "Name" "Value" "us-east-1"
+  assert_success
+
+  local readonly expected=$(cat <<END_HEREDOC
+{
+  "Reservations": []
+}
+END_HEREDOC
+)
+
+  assert_output_json "$expected"
+}
+
+@test "aws_get_instances_with_tag non-empty" {
+  local -r tag_key="Name"
+  local -r tag_value="Value"
+  local -r region="us-east-1"
+
+  create_mock_instance_with_tags "$tag_key" "$tag_value"
+  run aws_get_instances_with_tag "$tag_key" "$tag_value" "$region"
+  assert_success
+
+  local num_instances
+  num_instances=$(echo "$output" | jq -r '.Reservations | length')
+  assert_greater_than "$num_instances" 0
+}