Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to delete resources when deletion protection is enabled. #806

Open
wakeful opened this issue Dec 9, 2024 · 4 comments
Open

Fails to delete resources when deletion protection is enabled. #806

wakeful opened this issue Dec 9, 2024 · 4 comments
Assignees

Comments

@wakeful
Copy link
Contributor

wakeful commented Dec 9, 2024

Hey,

Currently, cloud-nuke fails if a resource it is trying to delete has "deletion protection" enabled. This feature is available across various resources such as DynamoDB, RDS, load balancers, and others.

What’s your opinion on extending the logic to allow cloud-nuke to disable "deletion protection" and retry the deletion? Or do you think this flag should be removed outside of the nuke process?

@james03160927
Copy link
Contributor

This is an interesting suggestion. Typically, users would rely on cloud-nuke to clean up resources left over from testing or those no longer needed, regardless of their settings. Therefore, it makes sense to delete such resources with a retry mechanism, even if deletion protection is enabled.

@james03160927 james03160927 self-assigned this Dec 10, 2024
@wakeful
Copy link
Contributor Author

wakeful commented Dec 10, 2024

Typically, users would rely on cloud-nuke to clean up resources left over from testing or those no longer needed, regardless of their settings. Therefore, it makes sense to delete such resources with a retry mechanism, even if deletion protection is enabled.

Exactly, I have the same feeling. However, since this would be a change in behaviour, we could add an extra option to preserve the current behaviour.

Let me create an initial PoC pull request with the changes, and we can discuss it in more detail.

Copy link
Contributor

SGTM. Thanks!

@james03160927
Copy link
Contributor

Friendly ping on this @wakeful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants