From c4a670c213a4341b257b9932cc6abab804baddf5 Mon Sep 17 00:00:00 2001
From: Nghia <nhn@alumni.stanford.edu>
Date: Tue, 23 Jan 2024 21:27:19 -0600
Subject: [PATCH] fix: additional pod/deployment labeling bool string
 encapsulation (#184)

---
 charts/k8s-service/templates/_deployment_spec.tpl | 4 ++--
 charts/k8s-service/values.yaml                    | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/charts/k8s-service/templates/_deployment_spec.tpl b/charts/k8s-service/templates/_deployment_spec.tpl
index b6a69c2..11510f8 100644
--- a/charts/k8s-service/templates/_deployment_spec.tpl
+++ b/charts/k8s-service/templates/_deployment_spec.tpl
@@ -89,7 +89,7 @@ metadata:
     app.kubernetes.io/instance: {{ .Release.Name }}
     app.kubernetes.io/managed-by: {{ .Release.Service }}
     {{- range $key, $value := .Values.additionalDeploymentLabels }}
-    {{ $key }}: {{ $value }}
+    {{ $key }}: "{{ $value }}"
     {{- end}}
 {{- with .Values.deploymentAnnotations }}
   annotations:
@@ -131,7 +131,7 @@ spec:
         gruntwork.io/deployment-type: main
         {{- end }}
         {{- range $key, $value := .Values.additionalPodLabels }}
-        {{ $key }}: {{ $value }}
+        {{ $key }}: "{{ $value }}"
         {{- end }}
 
       {{- with .Values.podAnnotations }}
diff --git a/charts/k8s-service/values.yaml b/charts/k8s-service/values.yaml
index 719fc2f..de12872 100644
--- a/charts/k8s-service/values.yaml
+++ b/charts/k8s-service/values.yaml
@@ -334,11 +334,11 @@ additionalDeploymentLabels: {}
 # NOTE: This variable is injected directly into the pod spec.
 podAnnotations: {}
 
-# additionalDeploymentLabels will add the provided map to the labels for the Pods created by the deployment resource.
+# additionalPodLabels will add the provided map to the labels for the Pods created by the deployment resource.
 # this is in addition to the helm template related labels created by the chart
 # The keys and values are free form, but subject to the limitations of Kubernetes labelling.
 # The match labels for the deployment aren't affected by these additional labels
-# NOTE: This variable is injected directly into the deployment spec.
+# NOTE: This variable is injected directly into the pod spec.
 additionalPodLabels: {}
 
 # minPodsAvailable specifies the minimum number of pods that should be available at any given point in time. This is