NPE on certain types of exception table entries

[gfredericks]

I'm not sure under what circumstances this occurs, and couldn't get an easy-to-reproduce case, but I was decompiling something produced by the clojure compiler (one of the init classes for a namespace, I think), and got an NPE on this line.

The javadoc for IExceptionTableEntry says "Returns the catch type name, null if getCatchTypeIndex() returns 0. This is the case for any exception handler"; which is a bit confusing, but I think it might mean "this is the case for an exception handler with catch-type "any"", which is the exact string printed by javap -c for this class.

So this is my workaround, but I'm not a dentist so I can't say confidently that it's correct:

(extend-protocol no.disassemble.r/Coerce
  org.eclipse.jdt.core.util.IExceptionTableEntry
  (coerce [e]
    {:start-pc   (.getStartPC e)
     :end-pc     (.getEndPC e)
     :handler-pc (.getHandlerPC e)
     :catch-type (if-let [bytes (.getCatchType e)]
                   (String. bytes)
                   "java/lang/Throwable")}))