Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phrasing in first notebook, re alleles #1

Open
hyanwong opened this issue Jun 9, 2022 · 5 comments
Open

Phrasing in first notebook, re alleles #1

hyanwong opened this issue Jun 9, 2022 · 5 comments

Comments

@hyanwong
Copy link

hyanwong commented Jun 9, 2022

You say

The tree consists of nodes, which represent the alleles held by different chromosomes in the history of the sample, and edges, which represent genealogical relationships between the alleles.

But I think it might be read as the nodes representing alleles (which they don't, of course). We normally say that the nodes represent genomes, I think? The genomes can carry mutations, which result in alleles being observed.

@hyanwong
Copy link
Author

hyanwong commented Jun 9, 2022

Similarly for other mentions of "alleles" in that notebook, I would say, e.g. "Suppose we have a sample of 4 alleles" - I think you mean genomes here. I could see the current phrasing as meaning 4 alleles at a single site.

@gtsambos
Copy link
Owner

gtsambos commented Jun 9, 2022 via email

@hyanwong
Copy link
Author

hyanwong commented Jun 9, 2022

Hmm, well an allele is something different, right? Two sample nodes can contain the same allele at a locus. The node is not an allele itself.

Could you just say " the nodes represent genomes or regions of genomes, here we've picked a short region and so the relationship is just a simple tree" - or something?

@gtsambos
Copy link
Owner

gtsambos commented Jun 9, 2022

Yes, I guess I could say "a region spanned by a single nucleotide base"

@hyanwong
Copy link
Author

hyanwong commented Jun 9, 2022

Or "a short region of genome, perhaps just a single base"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants