Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename few fonctions in lib/redmine_gtt/issue_query_patch.rb #327

Open
CtrlMajSup opened this issue Jul 9, 2024 · 4 comments
Open

Rename few fonctions in lib/redmine_gtt/issue_query_patch.rb #327

CtrlMajSup opened this issue Jul 9, 2024 · 4 comments

Comments

@CtrlMajSup
Copy link

Hello,
I had compatibility problems with another plugin that also worked on queries. So I made some changes to your patch by renaming :
initialize_available_filters to initialize_available_filters_with_gtt,
available_columns to available_columns_with_gtt and
issue to issue_with_gtt.
Inside issue_query_patch.rb
At first glance, this doesn't affect the gtt plugin. Perhaps this small change would solve the problem #151, #252 or others.

Thanks for updating to v5.1.0 👍

@dkastl
Copy link
Member

dkastl commented Jul 10, 2024

Thank you for sharing this suggestion. Would be able to provide a pull request, which then also gives you the credits.

Just out of curiousity, what are the plugins using the same names?

@CtrlMajSup
Copy link
Author

Apologies for the delay! It turns out that the conflicting plugin is the paid redmine_db plugin from AlphaNode. This plugin introduces entities similar to those in the redmine_supply plugin, and they both use the output filter tool on their entities. I initially tried modifying their plugin, but unfortunately, it didn’t work. However, when I applied the same changes to the redmine_gtt plugin, there was no conflict this time.

@dkastl
Copy link
Member

dkastl commented Oct 18, 2024

Thanks for coming back. You mention the supply plugin, but this would be another repository.

If you want these changes to be included in the plugin, it would be best if you could submit a pull request.

@dkastl
Copy link
Member

dkastl commented Nov 26, 2024

@CtrlMajSup , in case you can suggest your code changes with a pull request, I can take a look and it can become part of the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants