guardian/eslint-config-typescript v12 (#14747)

This involved some dependency updates, including updating
`typescript-eslint` from v7 to v8, which came with a number of breaking
changes, detailed here:

https://typescript-eslint.io/blog/announcing-typescript-eslint-v8/

The first set of changes required to handle this were to our ESLint
config.

`no-var-requires` has been deprecated in favour of `no-require-imports`,
and the former has been replaced by the latter in the `recommended`
preset, which `guardian/eslint-config-typescript` extends. However, we
had the former turned off, so this updates our config to turn the latter
off instead. See:

- https://typescript-eslint.io/blog/announcing-typescript-eslint-v8/#rule-breaking-changes
- https://typescript-eslint.io/blog/announcing-typescript-eslint-v8/#updated-configuration-rules

`ban-types` has been removed and replaced with `no-restricted-types`,
`no-empty-object-type`, `no-unsafe-function-type` and
`no-wrapper-object-types`. Previously we used `extendDefaults` to
include the latter three rules. That option no longer exists, but
they're included in the `recommended-type-checked` preset, which
`guardian/eslint-config-typescript` extends, so they should still be
present in our config. The remainder of our `ban-types` config involved
banning a list of configurable types, which is now handled by
`no-restricted-types`. See:

- https://typescript-eslint.io/blog/announcing-typescript-eslint-v8/#replacement-of-ban-types
- https://typescript-eslint.io/blog/announcing-typescript-eslint-v8/#updated-configuration-rules

The second set of changes are to our source files, to fix issues
surfaced by the rule changes. These have pre-emptively been handled in
earlier commits, and amount to following these rules:

- `no-unused-expressions`
- `prefer-promise-reject-errors`
- `no-empty-object-type`
- `no-unsafe-function-type`

There is one exception to this, where `prefer-promise-reject-errors` has
been disabled for a particular issue in AR.

Author: JamieB-gu

apps-rendering/config/.eslintrc.js

@@ -118,7 +118,7 @@ module.exports = {
 		{
 			files: ['**/*.tsx'],
 			rules: {
-				'@typescript-eslint/ban-types': [
+				'@typescript-eslint/no-restricted-types': [
 					'error',
 					{
 						types: {
@@ -132,7 +132,6 @@ module.exports = {
 							'React.FC':
 								'Please use const MyThing = ({foo, bar}: Props) instead',
 						},
-						extendDefaults: true,
 					},
 				],
 			},

apps-rendering/package.json

@@ -46,7 +46,7 @@
 		"@guardian/cdk": "62.0.1",
 		"@guardian/content-api-models": "31.0.0",
 		"@guardian/content-atom-model": "6.1.0",
-		"@guardian/eslint-config-typescript": "11.0.0",
+		"@guardian/eslint-config-typescript": "12.0.0",
 		"@guardian/libs": "22.0.0",
 		"@guardian/renditions": "0.2.0",
 		"@guardian/source": "9.0.0",
@@ -75,7 +75,7 @@
 		"compression": "1.8.0",
 		"constructs": "10.4.2",
 		"core-js": "3.33.3",
-		"eslint": "8.56.0",
+		"eslint": "8.57.1",
 		"eslint-plugin-jsx-a11y": "6.7.1",
 		"eslint-plugin-react": "7.33.2",
 		"express": "5.1.0",

apps-rendering/src/server/decoders.ts

@@ -33,6 +33,8 @@ const decodeContent =
 
 			return decoder.read(protocol);
 		} else {
+			/* eslint-disable-next-line @typescript-eslint/prefer-promise-reject-errors --
+			 * Part of an upgrade to get this rule enabled. */
 			return Promise.reject('Invalid request');
 		}
 	};

dotcom-rendering/.eslintrc.js

@@ -212,7 +212,7 @@ module.exports = {
 			files: ['**/**.js'],
 			rules: {
 				'global-require': 'off',
-				'@typescript-eslint/no-var-requires': 'off',
+				'@typescript-eslint/no-require-imports': 'off',
 				'@typescript-eslint/no-unsafe-member-access': 'off',
 				'@typescript-eslint/no-misused-promises': 'off',
 			},
@@ -245,7 +245,7 @@ module.exports = {
 		{
 			files: ['**/**.tsx'],
 			rules: {
-				'@typescript-eslint/ban-types': [
+				'@typescript-eslint/no-restricted-types': [
 					'warn',
 					{
 						types: {
@@ -259,7 +259,7 @@ module.exports = {
 						},
 					},
 				],
-				'@typescript-eslint/ban-types': [
+				'@typescript-eslint/no-restricted-types': [
 					'error',
 					{
 						types: {
@@ -274,7 +274,6 @@ module.exports = {
 							'React.FC':
 								'Please use const MyThing = ({foo, bar}: Props) instead',
 						},
-						extendDefaults: true,
 					},
 				],
 			},

dotcom-rendering/package.json

@@ -34,7 +34,7 @@
 		"@guardian/cdk": "62.0.1",
 		"@guardian/commercial-core": "29.0.0",
 		"@guardian/core-web-vitals": "7.0.0",
-		"@guardian/eslint-config-typescript": "11.0.0",
+		"@guardian/eslint-config-typescript": "12.0.0",
 		"@guardian/identity-auth": "6.0.1",
 		"@guardian/identity-auth-frontend": "8.1.0",
 		"@guardian/libs": "26.0.1",
@@ -104,7 +104,7 @@
 		"curlyquotes": "1.5.5",
 		"dompurify": "3.2.4",
 		"dynamic-import-polyfill": "0.1.1",
-		"eslint": "8.56.0",
+		"eslint": "8.57.1",
 		"eslint-config-airbnb-base": "15.0.0",
 		"eslint-config-airbnb-typescript": "17.0.0",
 		"eslint-plugin-custom-elements": "0.0.8",