Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Sure Key Event Links Navigate In-Article #12729

Open
JamieB-gu opened this issue Oct 31, 2024 · 2 comments · Fixed by #12755
Open

Make Sure Key Event Links Navigate In-Article #12729

JamieB-gu opened this issue Oct 31, 2024 · 2 comments · Fixed by #12755
Assignees

Comments

@JamieB-gu
Copy link
Contributor

The key events links at the top of a liveblog or deadblog should be handled correctly by the apps such that they navigate to the block in the blog within the same webview.

Ensure that this behaviour is working as expected on both iOS and Android.

Image

@JamieB-gu JamieB-gu added this to the Decommission Templates milestone Oct 31, 2024
@DanielCliftonGuardian
Copy link
Contributor

In the android simulator these links navigate to the DCAR version.
In IOS simulator they navigate to the DCR version.

@JamieB-gu JamieB-gu moved this to This Sprint in WebX Team Nov 1, 2024
@marjisound marjisound self-assigned this Nov 4, 2024
@marjisound marjisound linked a pull request Nov 5, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from Review to Done in WebX Team Nov 7, 2024
@marjisound marjisound reopened this Nov 12, 2024
@github-project-automation github-project-automation bot moved this from Review to Triage in WebX Team Nov 12, 2024
@marjisound marjisound moved this from Triage to In Progress in WebX Team Nov 12, 2024
@marjisound
Copy link
Contributor

marjisound commented Nov 12, 2024

A summary of the navigation issue in the apps:
Using relative links has caused some issues on Android. When the blog page changes, the ad insertion mechanism doesn’t function correctly, likely due to the need for a WebView cleanup mechanism on page transitions.

Also, the back button isn’t retaining page history within the WebView, hence it takes the user out of the liveblog.

On the other hand, switching to full URLs to trigger the deep link handler has its own challenges. It appears to drop query parameters and URL fragments, so if we choose this approach, we’ll need to resolve the issue of missing parameters and fragments.

Approach to fix this
We had a session with ios & android today, and agreed that we can continue with the relative url approach but the android team needs to implement changes to support directly opening "next pages" in a new activity/fragment without going through deeplinks. However, it's not straightforward and they need some refactoring of how they open DCAR articles.

Action:
We need to negotiate with Naz and Alina on prioritising this work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Blocked
Development

Successfully merging a pull request may close this issue.

4 participants