Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deeply read component and pillarName issue #12823

Open
marjisound opened this issue Nov 12, 2024 · 0 comments
Open

Deeply read component and pillarName issue #12823

marjisound opened this issue Nov 12, 2024 · 0 comments
Milestone

Comments

@marjisound
Copy link
Contributor

marjisound commented Nov 12, 2024

DCR requires a minimum of 10 articles to display a "Deeply Read" section. Although Ophan is returning 10 items for all editions, when we retrieve CAPI, two of the articles' content results are missing the pillarName field, which is mandatory in frontend service.
The articles are:

In this file https://github.com/guardian/frontend/blob/main/common/app/agents/DeeplyReadAgent.scala#L39-L63 DeeplyReadAgent is filtering out items that are returned from Ophan. This reduces the item count to < 10 and therefore this is deemed less than the number necessary to display and no items are then forwarded to DCR to render.

Email thread https://groups.google.com/a/guardian.co.uk/g/dotcom.platform/c/ZJalr8GCTdo/m/Pray3IQpBwAJ

@github-project-automation github-project-automation bot moved this to Triage in WebX Team Nov 12, 2024
@marjisound marjisound moved this from Triage to Sprint Candidates in WebX Team Nov 12, 2024
@marjisound marjisound moved this from Sprint Candidates to This Sprint in WebX Team Nov 12, 2024
@marjisound marjisound added this to the Requests milestone Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: This Sprint
Development

No branches or pull requests

1 participant