Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom headers to requests #26

Open
gudarzi opened this issue May 19, 2024 · 6 comments
Open

Add custom headers to requests #26

gudarzi opened this issue May 19, 2024 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed up for grabs Open for contribution

Comments

@gudarzi
Copy link
Owner

gudarzi commented May 19, 2024

Add an option for users to add custom headers to their download requests

@gudarzi gudarzi added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers up for grabs Open for contribution labels May 19, 2024
@artoodeeto
Copy link

Hello It's me again. When you say custom headers are you talking about this part right here:

Screenshot 2024-10-04 at 5 01 56 PM

Basically a way to add custom file name?

@gudarzi
Copy link
Owner Author

gudarzi commented Oct 5, 2024

@artoodeeto No, it means any custom headers that users might want to add. Check this link: https://blog.postman.com/what-are-http-headers/

@artoodeeto
Copy link

artoodeeto commented Oct 5, 2024

Ohh im sorry. lols. as soon as i saw the UI for headers i thought thats what you meant, my bad. Oh yea. I could add this feature. Do you want the custom header per request so like per row we could do something like:

file-to-download | paused 0% | 0 B/s | Use Headers For Filename | X-custom: header 

or

a custom header for all?

Also may I know the use case for this? How should I use this on the backend? Thank you for you patience.

ps: wanted to add a image for the custom header with swagger but im so knew to .net im struggling to find it on the documentation. sorry about that.

@gudarzi
Copy link
Owner Author

gudarzi commented Oct 5, 2024

@artoodeeto I think it'd be easier to first implement it for all at once, than to do it per item. We need to let user add a list of headers, input a header name and a header value, and then send it to the backend. The backend then sends all of those headers with each request.

@artoodeeto
Copy link

ok so.

step 1: let user create a list custom header for all download items.

step 2: save all custom headers on the backend.

step 3: before user tries to download anything we must include all the custom headers that was saved by the user. (NOT REQUIRED FOR DOWNLOAD)

step 3.1: for all the consecutive downloads, we include the headers.

@gudarzi
Copy link
Owner Author

gudarzi commented Oct 5, 2024

@artoodeeto custom headers must be saved in frontend, not backend. with each download request to the backend, the frontend sends all cutom headers again, to the backend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed up for grabs Open for contribution
Projects
None yet
Development

No branches or pull requests

2 participants