Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion of unit tests to NUnit's Constraint model #258

Open
dodexahedron opened this issue Dec 2, 2023 · 5 comments
Open

Conversion of unit tests to NUnit's Constraint model #258

dodexahedron opened this issue Dec 2, 2023 · 5 comments

Comments

@dodexahedron
Copy link
Contributor

The old classic assertion style has been deprecated for quite a while, now, and NUnit 4 takes that a step further by actually moving them off to a separate project and namespace.

I've been working on converting the tests to the new model, in my repo.

I branched from your latest v2_latest_changes_pre_220 branch commit and work is going into convert-tests-to-constraint-model on my repo. I'll open up a PR at some point for easier tracking of what's going on, as work is done.

But I did have a couple of questions about TerminalGuiDesigner for you, @tznind , that came up as I have been going through the tests.
I'd like to chat with you at some point, when you have some time, both to get some clarity on a couple of questions as well as to bounce some ideas off of you regarding something it looks like I might be able to help out with - I just need to be sure I understand it properly before I go any further down that rabbit hole (which isn't that deep, but I want to be sure the intent and result is the same).

I've created a project and issues over at my fork to track the work.

Project: https://github.com/users/dodexahedron/projects/4

Main conversion issue: dodexahedron#1

Branch for conversion work: https://github.com/dodexahedron/TerminalGuiDesigner/tree/convert-tests-to-constraint-model

I'm opening this issue up over here mostly as a placeholder to indicate and link to work being done.
I'll file other issues related to it over there, since it's likely to get a bit noisy.

If you have any thoughts, requests, ideas, commentary, concerns, or whatever, just hit me up over there. :)

@dodexahedron
Copy link
Contributor Author

Opened #259 as draft PR to track here as work goes on over there.

@tznind
Copy link
Collaborator

tznind commented Dec 2, 2023 via email

@dodexahedron
Copy link
Contributor Author

dodexahedron commented Dec 2, 2023

Sounds great.

Looking forward to it. :)

It's a great tool for a great library, and I make plenty of use of both, so I'm more than happy to lend a hand. :)

@dodexahedron
Copy link
Contributor Author

dodexahedron commented Dec 3, 2023

Oh, by the way...

If you're in Scotland, I come to you from the past (I'm 7 hours behind you).

And a fun little tidbit... I have a friend who used to live in Dundee but is now in Wormit, I think.

@tznind
Copy link
Collaborator

tznind commented Dec 5, 2023

Its a fun place! Although a bit dreary at this time of year :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants