From 97c9c04e9f379a0632aec7297b9ca23b4529e408 Mon Sep 17 00:00:00 2001 From: Caio de Lima Granero Date: Mon, 2 Dec 2019 18:08:12 -0300 Subject: [PATCH 1/2] Change the type of GIACode because some zipcodes doesn't have it and the code was throwing Newtonsoft.Json.JsonSerializationException. --- ViaCEP.Tests/ZipCodeTests.cs | 17 +++++++++++++++-- ViaCEP/VIaCEPResult.cs | 2 +- 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/ViaCEP.Tests/ZipCodeTests.cs b/ViaCEP.Tests/ZipCodeTests.cs index 3da7b37..f7366e4 100644 --- a/ViaCEP.Tests/ZipCodeTests.cs +++ b/ViaCEP.Tests/ZipCodeTests.cs @@ -15,10 +15,23 @@ public void ValidateSearchByZipCode() { var result = ViaCEPClient.Search("03177010"); Assert.NotNull(result); - Assert.Equal("Rua Doutor João Batista de Lacerda", result.Street); + Assert.Equal("Rua Doutor Jo�o Batista de Lacerda", result.Street); Assert.Equal("Quarta Parada", result.Neighborhood); - Assert.Equal("São Paulo", result.City); + Assert.Equal("S�o Paulo", result.City); Assert.Equal("SP", result.StateInitials); } + + + /// + /// Validates if the search by zip code don't throw a exception if the address doesn't have a gia code + /// + /// + [Fact] + public void ValidateSearchByZipCodeWithoutGiaCode() + { + var result = ViaCEPClient.Search("22795641"); + Assert.NotNull(result); + Assert.Null(result.GIACode); + } } } diff --git a/ViaCEP/VIaCEPResult.cs b/ViaCEP/VIaCEPResult.cs index aaeddee..c630006 100644 --- a/ViaCEP/VIaCEPResult.cs +++ b/ViaCEP/VIaCEPResult.cs @@ -87,6 +87,6 @@ public sealed class ViaCEPResult /// The gia code. /// [JsonProperty("gia")] - public Int32 GIACode { get; set; } + public Int32? GIACode { get; set; } } } From d2c845804213e3980d7cf6f4fb84384057f63208 Mon Sep 17 00:00:00 2001 From: Caio de Lima Granero Date: Mon, 2 Dec 2019 18:10:25 -0300 Subject: [PATCH 2/2] Fix unicode style. --- ViaCEP.Tests/ZipCodeTests.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ViaCEP.Tests/ZipCodeTests.cs b/ViaCEP.Tests/ZipCodeTests.cs index f7366e4..d4226de 100644 --- a/ViaCEP.Tests/ZipCodeTests.cs +++ b/ViaCEP.Tests/ZipCodeTests.cs @@ -15,9 +15,9 @@ public void ValidateSearchByZipCode() { var result = ViaCEPClient.Search("03177010"); Assert.NotNull(result); - Assert.Equal("Rua Doutor Jo�o Batista de Lacerda", result.Street); + Assert.Equal("Rua Doutor João Batista de Lacerda", result.Street); Assert.Equal("Quarta Parada", result.Neighborhood); - Assert.Equal("S�o Paulo", result.City); + Assert.Equal("São Paulo", result.City); Assert.Equal("SP", result.StateInitials); }