-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Percentages only #69
Comments
Welcome to GitAuto! 🎉
@bhosley, You have 3 requests left in this cycle which refreshes on 2024-12-21 10:07:38+00:00. |
it prints 84% because the value 500 is being used as scale. Removing |
The default scale is 100. So the progress value that is returned is correct because
However, the progress bar itself is filled as I have attached an example of why this solution is incorrect. |
ah, got it. there was no way to use different values for the progress bar and the text. i thought the issue was just that the value 84, did not make sense. thanks for clarifying that 😅 |
@bhosley Pull request completed! Check it out here #75 🚀 Note: I automatically create a pull request for an unassigned and open issue in order from oldest to newest once a day at 00:00 UTC, as long as you have remaining automation usage. Should you have any questions or wish to change settings or limits, please feel free to contact [email protected] or invite us to Slack Connect. |
Description
The most recent update forces values to be percentages. Screenshot is from the readme examples.
Originally the behavior would print $420 (the assumed current state) new behavior prints $84, which doesn't really make sense.
If the narrowing of use-cases is intentional, perhaps the non-percentage examples should be removed. Further it seems that this would make prefixes and suffixes obsolete.
Logs
N/A
Screenshots
Additional information
No response
The text was updated successfully, but these errors were encountered: