Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Percentages only #69

Open
bhosley opened this issue Nov 27, 2024 · 5 comments · May be fixed by #70 or #75
Open

[BUG] Percentages only #69

bhosley opened this issue Nov 27, 2024 · 5 comments · May be fixed by #70 or #75
Labels
🐛 bug Issues related to bugs or errors 📝 documentation Tasks related to writing or updating documentation enhancement New feature or request gitauto GitAuto label to trigger the app in a issue. 🕒 low effort A task that can be completed in a few minutes 🛠 WIP Work in progress

Comments

@bhosley
Copy link

bhosley commented Nov 27, 2024

Description

The most recent update forces values to be percentages. Screenshot is from the readme examples.
Originally the behavior would print $420 (the assumed current state) new behavior prints $84, which doesn't really make sense.

If the narrowing of use-cases is intentional, perhaps the non-percentage examples should be removed. Further it seems that this would make prefixes and suffixes obsolete.

Logs

N/A

Screenshots

Screenshot 2024-11-26 at 22 50 40

Additional information

No response

Copy link

gitauto-ai bot commented Nov 27, 2024

Welcome to GitAuto! 🎉
Click the checkbox below to generate a PR!

  • Generate PR

@bhosley, You have 3 requests left in this cycle which refreshes on 2024-12-21 10:07:38+00:00.
If you have any questions or concerns, please contact us at [email protected].

@gstraccini gstraccini bot added the 🚦 awaiting triage Items that are awaiting triage or categorization label Nov 27, 2024
@bhosley bhosley linked a pull request Nov 27, 2024 that will close this issue
6 tasks
@gstraccini gstraccini bot added the 🛠 WIP Work in progress label Nov 27, 2024
@guibranco guibranco added 🐛 bug Issues related to bugs or errors 📝 documentation Tasks related to writing or updating documentation enhancement New feature or request 🕒 low effort A task that can be completed in a few minutes and removed 🚦 awaiting triage Items that are awaiting triage or categorization labels Nov 28, 2024
@ztest95
Copy link
Contributor

ztest95 commented Dec 5, 2024

it prints 84% because the value 500 is being used as scale. Removing scale=500 in query params results in a progress bar with the correct value

@bhosley
Copy link
Author

bhosley commented Dec 5, 2024

it prints 84% because the value 500 is being used as scale. Removing scale=500 in query params results in a progress bar with the correct value

The default scale is 100. So the progress value that is returned is correct because

progress_text = int(progress / scale * 100)

However, the progress bar itself is filled as progress / scale.
Thus only displays correctly if your progress value is itself a percentage.

I have attached an example of why this solution is incorrect.

Screenshot 2024-12-04 at 21 40 28

@ztest95
Copy link
Contributor

ztest95 commented Dec 5, 2024

ah, got it. there was no way to use different values for the progress bar and the text. i thought the issue was just that the value 84, did not make sense. thanks for clarifying that 😅

@gitauto-ai gitauto-ai bot added the gitauto GitAuto label to trigger the app in a issue. label Dec 11, 2024
Copy link

gitauto-ai bot commented Dec 11, 2024

@bhosley Pull request completed! Check it out here #75 🚀

Note: I automatically create a pull request for an unassigned and open issue in order from oldest to newest once a day at 00:00 UTC, as long as you have remaining automation usage. Should you have any questions or wish to change settings or limits, please feel free to contact [email protected] or invite us to Slack Connect.

@gitauto-ai gitauto-ai bot linked a pull request Dec 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Issues related to bugs or errors 📝 documentation Tasks related to writing or updating documentation enhancement New feature or request gitauto GitAuto label to trigger the app in a issue. 🕒 low effort A task that can be completed in a few minutes 🛠 WIP Work in progress
Projects
None yet
3 participants