Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csm_table.dat columns inconsistency #226

Open
navii98 opened this issue Jul 2, 2023 · 1 comment
Open

csm_table.dat columns inconsistency #226

navii98 opened this issue Jul 2, 2023 · 1 comment

Comments

@navii98
Copy link

navii98 commented Jul 2, 2023

In the info file along with the csm_table.dat the columns are defined as follows
Columns are: n, s, beta_fs, beta_rs, A
https://github.com/guillochon/MOSFiT/blob/7e7779b6932955eb3875ebab5fe3fd28745eeb17/mosfit/models/csm/data/info.txt#L1C1-L3C39

which is what the csm.py engine file expects
https://github.com/guillochon/MOSFiT/blob/7e7779b6932955eb3875ebab5fe3fd28745eeb17/mosfit/modules/engines/csm.py#L37C1-L44C38

But looking at the csm_table.dat file,
it seems like the first columns is representing s as it's value is varying from 0-2, and the second column varying from 6-14 is 'n'
https://github.com/guillochon/MOSFiT/blob/7e7779b6932955eb3875ebab5fe3fd28745eeb17/mosfit/models/csm/data/csm_table.dat

@mnicholl
Copy link
Collaborator

I thought I had commented on this but looks like I didn't!

I agree that it looks like the columns are the wrong way round. I think it doesn't cause a problem for the model because another typo cancels it out: in csm.py, the n and s swaps again between lines 47-49 and 77-79.

@villrv could you check this and fix if needed? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants