Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TTT tutorials: 23-T-24 Curved Support, 01-02-post-cap, 01-10-light-cap #848

Closed
jdegenstein opened this issue Jan 7, 2025 · 1 comment · Fixed by #912
Closed

Fix TTT tutorials: 23-T-24 Curved Support, 01-02-post-cap, 01-10-light-cap #848

jdegenstein opened this issue Jan 7, 2025 · 1 comment · Fixed by #912
Assignees
@jdegenstein
Labels
bug Something isn't working
Milestone
Gating Release 1.0.0

Comments

@jdegenstein
Copy link
Collaborator

https://build123d.readthedocs.io/en/latest/tttt.html#t-24-curved-support is not currently working correctly on build123d==0.8.0 (and higher most likely)
@jdegenstein jdegenstein self-assigned this Jan 7, 2025
@gumyr gumyr added the bug Something isn't working label Jan 14, 2025
@gumyr gumyr added this to the Gating Release 1.0.0 milestone Jan 14, 2025
@jdegenstein jdegenstein changed the title Fix TTT tutorial 23-T-24 Curved Support Fix TTT tutorials: 23-T-24 Curved Support, 01-02-post-cap, 01-10-light-cap Jan 15, 2025
@jdegenstein
Copy link
Collaborator Author

Also fix https://build123d.readthedocs.io/en/latest/tttt.html#party-pack-01-02-post-cap (wrong material)
Also fix https://build123d.readthedocs.io/en/latest/tttt.html#party-pack-01-10-light-cap (invalid shape)

fischman added a commit to fischman/build123d that referenced this issue Feb 23, 2025
@fischman
TooTallToby tutorials: unbreak and test.
9d0d184 
- Unbreak the three broken tutorials (fixes gumyr#848)
- Add assertions to all the tutorials so that non-raising means success
- Add the TTT examples to `test_examples.py` added recently for gumyr#909
fischman added a commit to fischman/build123d that referenced this issue Feb 23, 2025
@fischman
TooTallToby tutorials: unbreak and test.
7b9c87f 
- Unbreak the three broken tutorials (fixes gumyr#848)
  - This involved a rewrite of PPP-01-10 because I already had my own
    solution to that one and I couldn't easily tell what was going
    wrong with the previous solution.
- Add assertions to all the tutorials so that non-raising means success
- Add the TTT examples to `test_examples.py` added recently for gumyr#909
@fischman fischman mentioned this issue Feb 23, 2025
Merged
fischman added a commit to fischman/build123d that referenced this issue Feb 23, 2025
@fischman
TooTallToby tutorials: unbreak and test.
3e8bb44 
- Unbreak the three broken tutorials (fixes gumyr#848)
  - This involved a rewrite of PPP-01-10 because I already had my own
    solution to that one and I couldn't easily tell what was going
    wrong with the previous solution.
- Add assertions to all the tutorials so that non-raising means success
- Add the TTT examples to `test_examples.py` added recently for gumyr#909
- Also added sympy to development dependencies since one of the TTT
  examples uses it.
fischman added a commit to fischman/build123d that referenced this issue Mar 5, 2025
@fischman
TooTallToby tutorials: unbreak and test.
01d29ef 
- Unbreak the three broken tutorials (fixes gumyr#848)
  - This involved a rewrite of PPP-01-10 because I already had my own
    solution to that one and I couldn't easily tell what was going
    wrong with the previous solution.
- Add assertions to all the tutorials so that non-raising means success
- Add the TTT examples to `test_examples.py` added recently for gumyr#909
- Also added sympy to development dependencies since one of the TTT
  examples uses it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdegenstein jdegenstein

Labels
bug Something isn't working
Projects
None yet
Milestone
Gating Release 1.0.0
Development

Successfully merging a pull request may close this issue.

TooTallToby tutorials: unbreak and test. fischman/build123d
2 participants
@jdegenstein @gumyr