Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for highlighting non-aliased public namespace members. #7

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jrdoane
Copy link

@jrdoane jrdoane commented Jul 24, 2018

For example, allows full names like clojure.core/conj to get highlighted based on namespaces described in (all-ns).

@guns
Copy link
Owner

guns commented Jul 2, 2019

Hi, thanks for the patch! I'll review later this week during the holiday!

@jrdoane
Copy link
Author

jrdoane commented Jul 2, 2019

Since I made this PR I have actually made some other changes as well with respect to making vim-clojure-highlight work with the latest changes to vim-fireplace. I'm still working out some of the issues, so you might want to hold off on it for the time being. I can branch off the last commit for this particular change if you want.

@jrdoane
Copy link
Author

jrdoane commented Jul 2, 2019

I submitted an issue on the fireplace project and heard back from Tim Pope and he suggested a different way of doing detection for fireplace, so I've updated my fork. If it looks good to you, have at it.

Just for reference: tpope/vim-fireplace#341

@SevereOverfl0w
Copy link

I got Syntax error compiling at (REPL:1:370). No such namespace: vim-clojure-highlight using this branch. It was also very slow on initial load of a namespace, it would be cool if it was async.

@walterl
Copy link

walterl commented Oct 14, 2019

I got the same error when running :ClojureHighlightReferences. This fixed it error for me:

diff --git a/autoload/vim_clojure_highlight.vim b/autoload/vim_clojure_highlight.vim
index 3492758..1345694 100644
--- a/autoload/vim_clojure_highlight.vim
+++ b/autoload/vim_clojure_highlight.vim
@@ -9,7 +9,7 @@ function! s:session_exists()
 endfunction
 
 function! s:require()
-       if fireplace#evalparse("(find-ns 'vim-clojure-highlight)") ==# ''
+       if fireplace#evalparse("(find-ns 'vim-clojure-highlight)") ==# v:null
                let buf = join(readfile(globpath(&runtimepath, 'autoload/vim_clojure_highlight.clj')), "\n")
                call fireplace#session_eval('(do ' . buf . ')')
        endif

…espace to work with latest version of fireplace.
mefryar added a commit to mefryar/dotfiles that referenced this pull request Jul 23, 2021
This commit adds jrdoane's fork of vim-clojure-highlight since
guns/vim-clojure-highlight#7 has not yet been merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants