return in finally can swallow exceptions

[iritkatriel]

In

ChatterBot/chatterbot/logic/unit_conversion.py

Line 164 in 4ff8af2

return response

there is a return statement in a finally block, which would swallow any in-flight exception.

This means that if a BaseException (such as KeyboardInterrupt) is raised from the try body, or any exception is raised from one of the except: clauses, it will not propagate on as expected.

See also https://docs.python.org/3/tutorial/errors.html#defining-clean-up-actions.

[jocelyn1981]

邮件已收到，谢谢您！