Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n support #89

Open
dmantula opened this issue Jan 16, 2023 · 2 comments
Open

i18n support #89

dmantula opened this issue Jan 16, 2023 · 2 comments

Comments

@dmantula
Copy link
Contributor

dmantula commented Jan 16, 2023

This great theme definitely needs internationalization.

I like how the language selection with a dropdown is done here , although the implementation (see the source code here) is pretty inelegant and would work only for the landing page. Also, language names might be replaced by flags or 2-letter abbreviations, and "Other languages" might be replaced by currently active language flag/abbreviation.

The implementation would require a long-running pull request and joint efforts for:

  • i18n:
    • extract all the strings
    • fix the link referencing
    • change the configuration file format for the landing page, with backward compatibility
    • adopt the UI for RTL support (optional at the first steps)
  • l10n:
    • add localization for a minimal set of languages

To proceed with that, I would ask the community if some efforts have already been put into it, and if any pitfalls have been found with that.

Also, I would like to know who else would contribute.

@torvenkat
Copy link

I second this request. It will be a great addition.

@alejaboterob
Copy link

Hello! I would contribute to the implementation of language support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants