Fix accounts package using wrong server #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means we need to specify the url in a settings file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is my workaround for reloading logging a user out (closes #1)
This is a slightly different approach to the remote DDP problem that involves specifying the remote URL in a settings file so that it's available before the accounts package is loaded. It then uses a private API of the accounts package to get it to connect to the right server. The connection that the accounts package creates is then used for everything else.
I changed so much of the code and API and the solution is so brittle that I renamed the package on my fork, but this PR is for you to use or learn from or cherry pick from.