Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trilom doesn't allow CI testing on windows #24

Closed
julianstanley opened this issue Apr 13, 2022 · 2 comments
Closed

Trilom doesn't allow CI testing on windows #24

julianstanley opened this issue Apr 13, 2022 · 2 comments
Labels
maintenance Updating internal code performance, updating language support etc,

Comments

@julianstanley
Copy link
Collaborator

When I add multiple OSx to the github actions job, it fails on the trilom step on Windows: https://github.com/julianstanley/rendseq/actions/runs/2163972249

This is a known issue in trilom that someone fixed and opened a pull request for ~10 months ago : trilom/file-changes-action#124

But it hasn't been merged. To me, trilom looks like it isn't being actively maintained.

So I think, if we want CI tests on windows, we'll have to use something other than trilom

@julianstanley julianstanley added the maintenance Updating internal code performance, updating language support etc, label Apr 13, 2022
@miraep8
Copy link
Collaborator

miraep8 commented Apr 14, 2022

In fact we could actually get away from using Trilom at all, my only plan was to use it for the style checks so that as the repo grows/more and more files each user is only responsible for linting the files they touched/changed - however one would only expect linting to break for the other files if for some reason we changed the pre-commit in the future. - Arguably whoever made such a decision might then be responsible for re-formatting all the files to guarantee others don't have this issue? But - not really mission critical to do this check and we could get away with Trilom all together! In truth this is another idea I borrowed from open source example workflows. :)

To me - it seems like whoever made Trilom is only interested in it running on Ubuntu? You can kind of see that assumption built in in all their use cases.

At the end of the day I was planning on running all pytests anytime a change is made, so wouldn't be using Trilom or similar to run the test cases you wrote! :) And will be running them on all OS's! And probably the latest 3 versions of python?

Cheers, thanks for catching this!

@julianstanley
Copy link
Collaborator Author

Closed by #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Updating internal code performance, updating language support etc,
Projects
None yet
Development

No branches or pull requests

2 participants