Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy to PyPI #179

Open
cthoyt opened this issue Aug 18, 2021 · 3 comments
Open

Deploy to PyPI #179

cthoyt opened this issue Aug 18, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@cthoyt
Copy link
Member

cthoyt commented Aug 18, 2021

It might be nice to have a copy of this on PyPI. I considered that most users won't have access to our copy of the database, but it might be convenient at least for other tools that rely on the DB such as the curation interface

@pagreene
Copy link
Collaborator

It might be worth looking into. We considered this in the past, but some of the core dependencies have at various times required custom builds (looking at you psycopg2. However, I think they have since fixed it so you can install them just using pip, so this might be doable now.

On the other hand, I do worry that putting it up on pypi may imply it is general-use software more than it currently is. I feel like I would want to comb through it to make sure it is not explicitly tied to our particular infrastructure, and best of all has a way to deploy an infrastructure on AWS (e.g. using CloudFormation). These are also all generally good things worth trying to do, although I am not sure when they will get done.

@cthoyt
Copy link
Member Author

cthoyt commented Aug 18, 2021

ooo I thought pip install psycopg2-binary was pretty reliable at the moment. I think adjusting the README a bit to imply it's not general use is still fair game, but it would be great if you got a chance to take a look into this at some point! Thanks patrick :)

@pagreene
Copy link
Collaborator

They have (last I read) retired psycopg2-binary, and for a while you had to build it directly. I think they've since worked some magic so that the build is now part of pip install psycopg2. I haven't looked at it in a while though so my memory is fuzzy.

And yeah, I will keep this in mind to look into.

@pagreene pagreene added the enhancement New feature or request label Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants