Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing parameter name in template_model_to_petrinet_json export #353

Closed
liunelson opened this issue Aug 15, 2024 · 0 comments
Closed

Missing parameter name in template_model_to_petrinet_json export #353

liunelson opened this issue Aug 15, 2024 · 0 comments

Comments

@liunelson
Copy link

When I call mira.modeling.amr.petrinet.template_model_to_petrinet_json to convert a TemplateModel to a AMR JSON for export, the objects in semantics.ode.parameters are missing the name key.

Looking at petrinet.py, I see that no name is included if display_name = None.

Since the CIEMSS operators expect a name key, can we have a fallback like this?

if param.display_name:
    param_dict['name'] = param.display_name
else:
    param_dict['name'] = str(key)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants