First impressions and suggestions

[happysalada]

Hi!

This is just a collection of things I noticed on startup, feel free to ignore what you think is irrelevant.

• There seems to be some typescript errors in the holo-rea/modules/vf-graphql-holochain

> @valueflows/[email protected] build /Users/raphael/Projects/holo-rea/modules/vf-graphql-holochain
> tsc -p ./tsconfig.dev.json; node ./finish-build

../../node_modules/.pnpm/[email protected]/node_modules/jest-diff/build/diffLines.d.ts:8:13 - error TS1005: '=' expected.

8 import type { DiffOptions } from './types';
              ~

../../node_modules/.pnpm/[email protected]/node_modules/jest-diff/build/diffLines.d.ts:8:34 - error TS1005: ';' expected.

8 import type { DiffOptions } from './types';
                                   ~~~~~~~~~

../../node_modules/.pnpm/[email protected]/node_modules/jest-diff/build/index.d.ts:10:13 - error TS1005: '=' expected.

10 import type { DiffOptions } from './types';
               ~

../../node_modules/.pnpm/[email protected]/node_modules/jest-diff/build/index.d.ts:10:34 - error TS1005: ';' expected.

10 import type { DiffOptions } from './types';
                                    ~~~~~~~~~

../../node_modules/.pnpm/[email protected]/node_modules/jest-diff/build/index.d.ts:11:1 - error TS1128: Declaration or statement expected.

11 export type { DiffOptions, DiffOptionsColor } from './types';
   ~~~~~~

../../node_modules/.pnpm/[email protected]/node_modules/jest-diff/build/index.d.ts:11:13 - error TS1005: ';' expected.

11 export type { DiffOptions, DiffOptionsColor } from './types';
               ~

../../node_modules/.pnpm/[email protected]/node_modules/jest-diff/build/index.d.ts:11:52 - error TS1005: ';' expected.

11 export type { DiffOptions, DiffOptionsColor } from './types';
                                                      ~~~~~~~~~

../../node_modules/.pnpm/[email protected]/node_modules/jest-diff/build/printDiffs.d.ts:8:13 - error TS1005: '=' expected.

8 import type { DiffOptions, DiffOptionsNormalized } from './types';
              ~

../../node_modules/.pnpm/[email protected]/node_modules/jest-diff/build/printDiffs.d.ts:8:57 - error TS1005: ';' expected.

8 import type { DiffOptions, DiffOptionsNormalized } from './types';
                                                          ~~~~~~~~~


Found 9 errors.

a brief look at it, and it looks like the import type syntax has been introduced in typescript 3.8 https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html
However the package.json only reference "typescript": "3.4.5"
Maybe it's just a matter of updating typescript dep? Do you know what version you are running on your local machine?

• nix-build . fails on some cmake file missing. If it wasn't working initially, feel free to ignore this.
• Holochain released 5 more versions after 0.80, perhaps consider an update? (If it doesn't make a difference, feel free to ignore this).

Open to testing stuff

[adaburrows]

Changing pnpm-lock.yaml like so fix the issue for me:

@@ -2536,8 +2554,8 @@ packages:
       integrity: sha512-P/W9yOX/3oPZSpaYOCQzGqgCQRXn0FFO/V8bWrCQs+wLmvVVxk6CRBXALEvNs9OHIatlnlFokfhuDo2ug01ciw==
   /@types/jest-diff/24.3.0:
     dependencies:
-      jest-diff: 26.1.0
-    deprecated: 'This is a stub types definition. jest-diff provides its own type definitions, so you do not need this installed.'
+      jest-diff: 24.9.0
+    deprecated: This is a stub types definition. jest-diff provides its own type definitions, so you do not need this installed.
     dev: true
     resolution:
       integrity: sha512-vx1CRDeDUwQ0Pc7v+hS61O1ETA81kD04IMEC0hS1kPyVtHDdZrokAvpF7MT9VI/fVSzicelUZNCepDvhRV1PeA==

[pospi]

Hey Raphael, thanks for logging this! I did as you suggested and it looks like the errors went away. Much appreciated (:

Please feel free to log anything else that comes up, I just finished merging a major update. Not all tests are passing yet and some residual issues to take care of, but APIs are stable enough to build against with some hand-holding. See more at #174