Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Appreciation DNA #233

Open
pospi opened this issue Mar 25, 2022 · 0 comments
Open

Implement Appreciation DNA #233

pospi opened this issue Mar 25, 2022 · 0 comments
Labels
enhancement New feature or request good first issue not too involved, nice for newcomers & will introduce you to various parts of the system graphql-api Something at the layer of what is and isn't implemented that affects the graphql api

Comments

@pospi
Copy link
Member

pospi commented Mar 25, 2022

Includes the Appreciation record type CRUD zome and associated indexes. Agreement would be a good blueprint to follow as this is a relatively simple record type.

There is an inherent assumption that Appreciation should be kept separately from Observation, which might turn out to be false. In this configuration, cross-organisational appreciations would require all organisations to share an Appreciation DNA in order to see the records. In some configurations it might actually be better to bundle Appreciation with Observation and mirror the data between collaboration spaces, similarly to how Satisfaction and Fulfillment are mirrored between Observation and Planning. In such a configuration, organisations could view appreciations from external orgs without having to share visibility into their coordination spaces.

Note however that the indexes on EconomicEvent (appreciationOf and appreciatedBy) must always be co-located with the events in Observation. So, this might behoove enough cross-organisational visibility on its own. More thought is needed, probably best to exercise this via integration tests and see what makes sense.

DEFAULT_VF_MODULES needs to be extended to have appreciation added to the whitelist in order for queries & resolvers for this module to show up.

Ideally, #85 & #40 would be completed before starting so that there is a well-established and vetted pattern in use; otherwise it's just more stuff to refactor later.

@pospi pospi added enhancement New feature or request graphql-api Something at the layer of what is and isn't implemented that affects the graphql api good first issue not too involved, nice for newcomers & will introduce you to various parts of the system labels Mar 25, 2022
@pospi pospi added this to the Multi-DNA system core (MIP) milestone Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue not too involved, nice for newcomers & will introduce you to various parts of the system graphql-api Something at the layer of what is and isn't implemented that affects the graphql api
Projects
None yet
Development

No branches or pull requests

1 participant