Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement correct ordering of self-referential local-only indexes #374

Open
pospi opened this issue Oct 17, 2022 · 0 comments
Open

Implement correct ordering of self-referential local-only indexes #374

pospi opened this issue Oct 17, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@pospi
Copy link
Member

pospi commented Oct 17, 2022

This issue currently only affects EconomicResource.contains and manifests as nondeterministic return order of contained resources.

It should be resolved as part of #337 and will definitely go away once we move to an integrity zome architecture in #264; but deserves its own issue as there are some additional DHT storage bloat optimisations that might need to be made in addressing it. In short, since hdk_semantic_indexes_zome_lib::sync_index does not currently create time indexes for the destination link targets, and these are triggered separately in hdk_records::identity_helpers::create_entry_identity, you don't actually get bidirectional time indexes created unless you manually request that both sides of an index be created. This breaks for self-referential indexes, since only 1 RPC call is made to update them (both sides being in the same zome means this is sufficient for updating the semantic indexing components of the link structure).

@pospi pospi added the bug Something isn't working label Oct 17, 2022
@pospi pospi added this to the Stable core components (MVP) milestone Oct 17, 2022
pospi added a commit that referenced this issue Oct 17, 2022
Connoropolous pushed a commit that referenced this issue Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant