Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom extension resolvers are unable to pass base64-encoded Holochain identifiers to thirdparty zomes #395

Open
pospi opened this issue Jul 27, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@pospi
Copy link
Member

pospi commented Jul 27, 2023

The 'magic' handling / recursing logic in the GraphQL connector module's connection.ts interferes with any other Holochain modules which could conceivably be bound to a thirdparty resolver; if those modules are expecting EntryHashB64 or ActionHashB64 as arguments. In these cases the encoding logic will interfere and deserialize such string values to a Uint8Array prior to transmission through @holochain/client.

Fixing this would mean updating @valueflows/vf-graphql-holochain to handle encoding of specific fields (id & revisionId for most record types, plus other 'foreign key' identifiers); rather than the current recursive field detection and de/serialization.

A side-benefit is this would actually make the connection logic quite a bit faster, if slightly more heavyweight in terms of byte size.

@pospi pospi added the bug Something isn't working label Jul 27, 2023
@pospi pospi added this to the Stable core components (MVP) milestone Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant