Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Preserve chatbot feedback after data change #2442 #2443

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Conversation

marek-mihok
Copy link
Contributor

@marek-mihok marek-mihok commented Dec 30, 2024

The PR fulfills these requirements: (check all the apply)

  • It's submitted to the main branch.
  • When resolving a specific issue, it's referenced in the PR's title (e.g. feat: Add a button #xxx, where "xxx" is the issue number).
  • When resolving a specific issue, the PR description includes Closes #xxx, where "xxx" is the issue number.
  • If changes were made to ui folder, unit tests (make test) still pass.
  • New/updated tests are included

NOTE: The test needs to be fixed (or removed if unable to fix). For some reason the new message is not present in document when updating data using rerender function from testing library so the test does not reproduce the issue being fixed in this PR.

Closes #2442

Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marek-mihok!

@mturoci mturoci merged commit c60591a into main Jan 7, 2025
5 checks passed
@mturoci mturoci deleted the fix/issue-2442 branch January 7, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feedback is not preserved on chatbot data change
2 participants