Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warnings with PHP 8.2 #523

Open
thepurpleblob opened this issue Oct 20, 2023 · 1 comment
Open

Deprecation warnings with PHP 8.2 #523

thepurpleblob opened this issue Oct 20, 2023 · 1 comment

Comments

@thepurpleblob
Copy link

As the plugin supports Moodle 4.2 and Moodle 4.2 supports PHP 8.2 then I would expect it to work with PHP 8.2. It throws deprecation notices as follows...

Deprecated: Creation of dynamic property H5PCore::$url is deprecated in /app/public/mod/hvp/library/h5p.classes.php on line 2145

Deprecated: Creation of dynamic property H5PCore::$development_mode is deprecated in /app/public/mod/hvp/library/h5p.classes.php on line 2147

Deprecated: Creation of dynamic property H5PCore::$aggregateAssets is deprecated in /app/public/mod/hvp/library/h5p.classes.php on line 2149

Deprecated: Creation of dynamic property H5PCore::$fullPluginPath is deprecated in /app/public/mod/hvp/library/h5p.classes.php on line 2152

Deprecated: Creation of dynamic property H5PCore::$relativePathRegExp is deprecated in /app/public/mod/hvp/library/h5p.classes.php on line 2155

This would seem to be the following.. https://php.watch/versions/8.2/dynamic-properties-deprecated

@acquaalta
Copy link

Hi @thepurpleblob,
I have the plugin installed on a Moodle 4.3 with PHP 8.2, a test environment, and the plugin (CRON, actually) throws these errors too. Did you notice any actual issues while using the plugin? I wonder what's the effect of this issue.

Although I successfully uploaded an H5P content into the H5P activity that I created, and also successfully edited the content and viewed it, it's possible that there is an issue that I didn't notice yet, issue in the sense of an actual bug in the plugin, and not "only" deprecation messages that are sent by the CRON.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants