Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make hMRI toolbox compatible with BIDS #20

Open
nbeliy opened this issue Mar 11, 2021 · 1 comment
Open

Make hMRI toolbox compatible with BIDS #20

nbeliy opened this issue Mar 11, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request futureplans

Comments

@nbeliy
Copy link

nbeliy commented Mar 11, 2021

Dear developers, can you make the toolbox compatible with datasets folowing BIDS?

The problem comes when toolbox tries to extract metadata for images from sidecar json and expects to find hMRI structure.
When it fails, the defaults are used.

I see two posiibilities to make toolbox compatible:

1. Retrieve the metadata from json in bids

Make get_metadata_val function a front-end, which checks if acqpar is present in json structure, if so call the get_metadata_val_classic witch retrieves the hMRI parameters, else calls get_metadata_val_bids retrieving bids metadata.

Pros:

  • Non invasive, should be immediately compatible with toolbox without further adjustments
  • Easy to implement

Cons:

  • Not all hMRI metadata has corresponding field in bids json, for example B1FAValues
  • Some values may be defined differently, for ex ReadoutDuration in BIDS uses FSL definition and not SPM one.

2. Allow user to pass parameters directly from batch script

In batch interface add a menu called something like "Processing parameters", where user can add parameter in form:
<key> <value> where key is hMRI metadata name, and value corresponds to value.

Then get_metadata_val checks first in these parameters and if it fails checks in json structure.

Pros:

  • Add flexibility to processing data, allow to pass key parameters dynamically even if image files has no metadada

Cons:

  • Need to adapt all hMRI tools
@lukeje lukeje added the enhancement New feature or request label Sep 10, 2021
siawoosh pushed a commit to siawoosh/hMRI-toolbox that referenced this issue Mar 28, 2022
add temporary folder for tests to test template
@lukeje
Copy link
Member

lukeje commented Jan 6, 2023

There is a now a wiki page to document the current status of BIDS compatibility: https://github.com/hMRI-group/hMRI-toolbox/wiki/BIDS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request futureplans
Projects
None yet
Development

No branches or pull requests

3 participants