Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functions in spm12 hides native functions in spm #24

Open
nbeliy opened this issue Apr 22, 2021 · 2 comments
Open

Functions in spm12 hides native functions in spm #24

nbeliy opened this issue Apr 22, 2021 · 2 comments
Assignees

Comments

@nbeliy
Copy link

nbeliy commented Apr 22, 2021

The functions in hMRI-toolbox/spm12 folder are added to matlab by default.
All of them except spm_dicom_dict effectively hides corresponding function in spm12.

This is a dangerous situation and those functions must be either moved to it own namespace,
or changed names to hmri_...

@ChristophePhillips
Copy link
Contributor

Agreed.

These spm12 functions were added at the time because they were not part of the public SPM release yet. Now it would be safer to rely on the SPM distribution, which ensures that the functions are fixed when needed. The small risk is the that some new features breaks back compatibility but this is IMO still less risky.

For the sake of completeness, I would also introduce a SPM version check when hMRI gets initialized. This way we would warn the user that their version of SPM is too old...

@nbeliy
Copy link
Author

nbeliy commented May 4, 2021

If hMRI toolbox is dependent on SPM, then using the SPM version of these functions is preferable, hoping that they do not change interface

lukeje added a commit that referenced this issue Jul 20, 2022
Refactoring, tests and weighted least squares
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants