Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Avoid undefined array key when determining strategy #25

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[BUGFIX] Avoid undefined array key when determining strategy #25

wants to merge 3 commits into from

Conversation

brotkrueml
Copy link

Resolves: #24

@PhilippKuhlmay
Copy link

Hi @brotkrueml
I get the same Error inside /page_speed_insights/Classes/FormEngine/Elements/History.php:48 when trying to edit the pagesettings of a page.
After changing this line into $this->strategyToShow = ($GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['page_speed_insights']['strategyToShow'] ?? '') ?: 'mobile'; the error disappeared. So this line should be changed too. Thanks.

@brotkrueml brotkrueml changed the title [BUGFIX] Avoid undefined array key in DrawHeaderHook [BUGFIX] Avoid undefined array key when determining strategy Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP 8.0: PHP Warning: Undefined array key "strategyToShow"
2 participants
@brotkrueml @PhilippKuhlmay