Add nonprofit sorting functionality (#72)

Closes #62

### Overview

This PR implements sorting and filtering capabilities for the nonprofits
GraphQL endpoint. The goal was to enable users to sort nonprofits
alphabetically (A-Z and Z-A), by most recent project start date, and by
status (ACTIVE/INACTIVE), as well as filter nonprofits by chapter IDs
and status.

**Key Changes:**
- Added `NonprofitSortOption` enum with four sorting options: `A_TO_Z`,
`Z_TO_A`, `MOST_RECENT`, and `STATUS`
- Implemented derived status computation logic that determines if a
nonprofit is ACTIVE or INACTIVE based on its associated projects
- Added `status` field to the `Nonprofit` GraphQL type
- Enhanced the `nonprofits` query to accept optional `chapterIds`,
`statuses`, and `sort` parameters
- Implemented multi-level sorting that allows combining multiple sort
options in order of precedence
- Added comprehensive filtering by chapter IDs and status types

**Implementation Details:**
- Status is derived dynamically from `nonprofit_chapter_project`
relationships (ACTIVE if there's an ongoing project, INACTIVE otherwise)
- Sorting is performed in-memory after fetching nonprofits to support
complex multi-level sorting
- All query parameters are optional for backward compatibility
- Chapter filtering uses Prisma relation filters for efficiency

### Testing

**Unit Tests:**
- Added comprehensive unit tests in
`tests/unit/services/nonprofits.service.test.ts` covering:
- Status derivation logic (ACTIVE vs INACTIVE based on project dates and
status)
  - A-Z and Z-A alphabetical sorting
  - Most recent sorting (by latest project start date)
  - Status sorting (ACTIVE before INACTIVE)
  - Combined multi-level sorting (e.g., STATUS + MOST_RECENT + A_TO_Z)
  - Chapter filtering
  - Status filtering
  - Edge cases (nonprofits without projects, multiple projects, etc.)

**Integration Tests:**
- Added new integration test file
`tests/integration/graphql/nonprofits-sorting.test.ts` with end-to-end
GraphQL tests:
  - A to Z sorting
  - Z to A sorting
  - Most recent sorting
  - Status sorting
  - Status filtering (ACTIVE only)
  - Chapter filtering
  - Combined sorting (STATUS + MOST_RECENT)

All tests pass successfully. The implementation maintains backward
compatibility - existing queries without the new parameters continue to
work as before.

### Screenshots / Screencasts

N/A - This is a backend API change with no frontend components affected.

### Checklist

- [x] Code is neat, readable, and works
- [x] Code is commented where appropriate and well-documented
- [x] Commit messages follow our
[guidelines](https://www.conventionalcommits.com)
- [x] Issue number is linked
- [x] Branch is linked
- [x] Reviewers are assigned (one of your tech leads)

### Notes

- The status field is computed dynamically on each query rather than
being persisted in the database, which ensures accuracy but may have
performance implications for very large datasets
- Nonprofits without any projects are considered INACTIVE
- When sorting by MOST_RECENT, nonprofits without projects appear last
- The implementation follows the existing codebase patterns and
maintains consistency with other similar features (e.g., project
sorting)
- All linting errors have been resolved and the code passes ESLint
checks

---------

Co-authored-by: Sophia Chang <[email protected]>

Author: nmokaria27

.DS_Store

@@ -1,12 +1,11 @@
-# Server Configuration (using different ports for testing)
-PORT=4001
-REST_PORT=4002
-GRAPHQL_PORT=4003
+# Test Database Configuration
+DATABASE_URL=postgresql://postgres:test_password@localhost:5433/test_db?schema=public
+DIRECT_URL=postgresql://postgres:test_password@localhost:5433/test_db?schema=public
 
-# Application Configuration
+# Environment
 NODE_ENV=test
-SEED_DATA=false
 
-# Optional: Add any API keys or other configuration
-# JWT_SECRET=your_jwt_secret_here
-# CORS_ORIGIN=http://localhost:3000
+# Server Configuration
+PORT=3001
+REST_PORT=3002
+GRAPHQL_PORT=3003

.env.example

@@ -8,3 +8,6 @@ logs/
 
 # Coverage files
 coverage/
+REVIEW_SUMMARY.md
+NONPROFIT_SORTING_IMPLEMENTATION.md
+.gitignore

.env.test

@@ -2,21 +2,36 @@ import {
   createNonprofit,
   createNonprofitSchema,
   deleteNonprofit,
-  getAllNonprofits,
   getNonprofitById,
+  getNonprofitsWithFilters,
   updateNonprofit,
   updateNonprofitSchema,
 } from '../../../core';
 import { GraphQLError } from 'graphql';
 import { z } from 'zod';
+import type {
+  StatusType,
+  NonprofitSortOption,
+} from '../../../core/services/nonprofits.service';
 
 // Infer TypeScript types directly from your Zod schemas
 type CreateNonprofitInput = z.infer<typeof createNonprofitSchema>;
 type UpdateNonprofitInput = z.infer<typeof updateNonprofitSchema>;
 
+interface NonprofitsQueryArgs {
+  chapterIds?: string[];
+  statuses?: StatusType[];
+  sort?: NonprofitSortOption[];
+}
+
 export const nonprofitResolvers = {
   Query: {
-    nonprofits: () => getAllNonprofits(),
+    nonprofits: (
+      _parent: unknown,
+      { chapterIds, statuses, sort }: NonprofitsQueryArgs
+    ) => {
+      return getNonprofitsWithFilters({ chapterIds, statuses, sort });
+    },
     nonprofit: async (_parent: unknown, { id }: { id: string }) => {
       const nonprofit = await getNonprofitById(id);
       if (!nonprofit) {
@@ -43,10 +58,13 @@ export const nonprofitResolvers = {
     },
     updateNonprofit: (
       _parent: unknown,
-      { id, input }: { id: string; input: UpdateNonprofitInput }
+      {
+        nonprofit_id,
+        input,
+      }: { nonprofit_id: string; input: UpdateNonprofitInput }
     ) => {
       const validatedInput = updateNonprofitSchema.parse(input);
-      return updateNonprofit(id, validatedInput);
+      return updateNonprofit(nonprofit_id, validatedInput);
     },
     deleteNonprofit: (_parent: unknown, { id }: { id: string }) => {
       return deleteNonprofit(id);

.gitignore

@@ -1,4 +1,11 @@
 export const nonprofitSchemaString = `
+  enum NonprofitSortOption {
+    A_TO_Z
+    Z_TO_A
+    MOST_RECENT
+    STATUS
+  }
+
   type Nonprofit {
     nonprofit_id: ID!
     name: String!
@@ -8,10 +15,15 @@ export const nonprofitSchemaString = `
     contact_id: String!
     created_at: String!
     updated_at: String!
+    status: StatusType!
   }
 
   type Query {
-    nonprofits: [Nonprofit!]!
+    nonprofits(
+      chapterIds: [ID!]
+      statuses: [StatusType!]
+      sort: [NonprofitSortOption!]
+    ): [Nonprofit!]!
     nonprofit(id: ID!): Nonprofit
   }
 

package-lock.json

@@ -2,10 +2,19 @@
 import dotenv from 'dotenv';
 import { z } from 'zod';
 
+const envFilePath = (() => {
+  switch (process.env.NODE_ENV) {
+    case 'production':
+      return '.env';
+    case 'test':
+      return '.env.test';
+    default:
+      return '.env.local';
+  }
+})();
+
 dotenv.config({
-  // path: process.env.NODE_ENV === 'test' ? '.env.test' : '.env',
-  // TODO: fix once we get our own test database set up that's not our prod database
-  path: '.env',
+  path: envFilePath,
 });
 
 // Define a schema for your environment variables

src/api/graphql/resolvers/nonprofits.resolvers.ts

@@ -9,6 +9,14 @@ export * from './services/roles.service';
 export * from './services/sponsors.service';
 export * from './services/volunteer.service';
 
+// Export types for GraphQL resolvers
+export type {
+  StatusType,
+  NonprofitSortOption,
+  GetNonprofitsFilters,
+  EnrichedNonprofit,
+} from './services/nonprofits.service';
+
 // Validators
 export * from './validators/chapters.validator';
 export * from './validators/companies.validator';