Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve all eslint errors #609

Closed
1 task done
LoTerence opened this issue Nov 7, 2024 · 7 comments · Fixed by #639
Closed
1 task done

Resolve all eslint errors #609

LoTerence opened this issue Nov 7, 2024 · 7 comments · Fixed by #639
Assignees
Labels
feature: Quality Control good first issue Good for newcomers role: frontend Pertains to frontend tasks size: 2pt Can be done in 7-12 hours

Comments

@LoTerence
Copy link
Member

LoTerence commented Nov 7, 2024

Overview

As a developer, we should resolve all eslint errors, so that the code maintains a high standard of quality and follows best practices, improving readability, consistency, and reducing the risk of bugs.

If you go into the frontend folder, and run npm run lint, 47 eslint errors and warnings come up.

Screenshot:
image

Action Items

  • resolve all eslint errors

Resources/Instructions

Resources

@nooriaali9
Copy link
Member

Hi @LoTerence this issue looks good, if it is currently being worked on, it can be moved to In progress.

@LoTerence LoTerence moved this from 🆕 New Issue Approval to 📋 Prioritized Backlog in P: CTJ: Project Board Nov 16, 2024
@LoTerence
Copy link
Member Author

@nooriaali9 I moved it to prioritized backlog.

Hey @irais-valenzuela if you are still working on this issue, could you move it to "In Progress" please? This is for PM stuff

@irais-valenzuela
Copy link
Member

Hi @LoTerence, Thank you for writing up this ticket! I wanted to let you know that I'll be unassigning myself to avoid holding things up on your end. I have a few more interviews coming up, and I won’t have much time to dedicate to this.

@irais-valenzuela irais-valenzuela removed their assignment Nov 16, 2024
@LoTerence LoTerence added the good first issue Good for newcomers label Jan 7, 2025
@irais-valenzuela irais-valenzuela self-assigned this Jan 13, 2025
@irais-valenzuela irais-valenzuela moved this from 📋 Prioritized Backlog to 🏗 In progress in P: CTJ: Project Board Jan 13, 2025
@nooriaali9
Copy link
Member

@irais-valenzuela Please update on this ticket - with the progress you've made on this!

@irais-valenzuela
Copy link
Member

This ticket has been completed. I'm just waiting on code review for it to be merged. The PR is here

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in P: CTJ: Project Board Feb 4, 2025
@LoTerence
Copy link
Member Author

PR merged, thank you Ida!

There are still 16 eslint warnings left. I will make a new PR to clean up the rest.

@LoTerence LoTerence reopened this Feb 4, 2025
@github-project-automation github-project-automation bot moved this from ✅ Done to 📋 Prioritized Backlog in P: CTJ: Project Board Feb 4, 2025
@LoTerence
Copy link
Member Author

Resolved with PR #640

@github-project-automation github-project-automation bot moved this from 📋 Prioritized Backlog to ✅ Done in P: CTJ: Project Board Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: Quality Control good first issue Good for newcomers role: frontend Pertains to frontend tasks size: 2pt Can be done in 7-12 hours
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants