diff --git a/_includes/wins-page/wins-card-template.html b/_includes/wins-page/wins-card-template.html index b616a5f9ab..1598eaa0a2 100644 --- a/_includes/wins-page/wins-card-template.html +++ b/_includes/wins-page/wins-card-template.html @@ -7,7 +7,11 @@ - + + +
diff --git a/_sass/components/_wins-page.scss b/_sass/components/_wins-page.scss index 913eefd091..088e559265 100644 --- a/_sass/components/_wins-page.scss +++ b/_sass/components/_wins-page.scss @@ -280,6 +280,17 @@ display: flex; } +.github-icon{ + width: 32px; + height: 32px; + max-width: 100%; +} + +.github-icon svg{ + width: 100%; + height: 100%; +} + @media #{$bp-below-desktop} { .wins-card { position: relative; diff --git a/assets/js/wins.js b/assets/js/wins.js index 45bd6886f2..531b664f4d 100644 --- a/assets/js/wins.js +++ b/assets/js/wins.js @@ -290,7 +290,6 @@ const cardTemplate = document.getElementById("wins-card-template"); const QUOTE_ICON_PATH = '/assets/images/wins-page/quote-icon.svg' const AVATAR_DEFAULT_PATH = "/assets/images/wins-page/avatar-default.svg" - const GITHUB_ICON = '/assets/images/wins-page/icon-github-small.svg'; const LINKEDIN_ICON = '/assets/images/wins-page/icon-linkedin-small.svg' const winsCardContainer = document.querySelector('#responses'); @@ -330,8 +329,7 @@ if (card[github_url].length > 0){ cloneCardTemplate.querySelector('.wins-card-github-icon').href = card[github_url]; - cloneCardTemplate.querySelector('.github-icon').src = GITHUB_ICON ; - cloneCardTemplate.querySelector('.github-icon').alt = `GitHub profile for ${card[name]}`; + cloneCardTemplate.querySelector('.github-icon').setAttribute('aria-label' ,`GitHub profile for ${card[name]}`); } else { cloneCardTemplate.querySelector('.wins-card-github-icon').setAttribute('hidden', 'true') }