Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submission flow success should bring user back to the feed instead of the "email submission confirmation" page. #182

Open
1 task
owenjoseph opened this issue Jul 29, 2019 · 11 comments

Comments

@owenjoseph
Copy link
Member

owenjoseph commented Jul 29, 2019

Context

Currently, the end of the feedback flow brings the user to a page that says to check their email for confirmation. Getting back to the feed is not obvious (based on user feedback).

Instead, successfully submitting feedback on an AgendaItem should bring the user immediately back to the feed where a pop-up should tell them to check their email for verification.

Tasks

Currently there exists a component called PositionFormFinalStep.jsx, which is being routed to as a separate page. Instead, that content should be presented as a pop-up after the user is directed back to the feed after a successful form submission (ConfirmFormContentComponent.jsx). Pop-up should look like this (fonts and colors approximated - inherit styling from latest style):

  • Develop ConfirmFormContentComponent.jsx and remove PositionFormFinalStep.jsx form last step of the item flow.

Files

Pop-up confirmation message
engage_formSubmission_success

@ldaws003
Copy link
Contributor

Hi, I'm interested in helping with this. How do I assign this to myself, and place it into In Progress?

@TeddyCr
Copy link
Contributor

TeddyCr commented Dec 3, 2019

@ldaws003 are you still working on this?

@ldaws003
Copy link
Contributor

ldaws003 commented Dec 3, 2019

Hi Teddy, I have not started working on this issue due me not being able to put this issue into In Progress in the Engage Project Plan since I am not a member of hackla on github.

@ldaws003
Copy link
Contributor

ldaws003 commented Dec 4, 2019

@TeddyCr Can I just get started on this and the other issue?

@TeddyCr
Copy link
Contributor

TeddyCr commented Dec 4, 2019

Sounds good. Thanks @ldaws003. Do not hesitate to connect with @joshbeme for any questions regarding the code structure and business logic.


@joshbeme for visibility

@ldaws003
Copy link
Contributor

Thank you

@TeddyCr
Copy link
Contributor

TeddyCr commented Dec 10, 2019

@ldaws003 talking with our UI/UX designer (@THaney15) he brought up a good point. This pop up should show up on the review submission page - after you click the submit button.

Then when you click on the close and return to feed button it should redirect you to the feed page.

Let me know if you have any questions.

image

@ldaws003
Copy link
Contributor

@TeddyCr Sounds good, would you also want the url to have this while the popup is there? https://smstaging.engage.town/#/emailConfirmation

@TeddyCr
Copy link
Contributor

TeddyCr commented Dec 12, 2019

@ldaws003, yes, that would be great.

@ldaws003
Copy link
Contributor

@TeddyCr sorry, couldn’t make the url change without the page reloading. Everything else seems to work and I made a pull request.

@TeddyCr
Copy link
Contributor

TeddyCr commented Dec 14, 2019

Sounds good. We'll review it and give any feedback if needed. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In progress (actively working)
Development

No branches or pull requests

5 participants