Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Link from react-router with Link prop in Header and Footer component #853

Open
jaronheard opened this issue Aug 27, 2019 · 0 comments

Comments

@jaronheard
Copy link
Contributor

What

For the following components designed to be used outside of civicplatform.org

Footer
Header
NavRouterLink (used in Header)
NavSubMenu (used in Header)

Instead of directly using Link from react-router, require a Link component to be passed in as a prop.

For components that use Header and Footer that are used solely within civicplatform.org (e.g. PageLayout), directly use Link from react-router here instead

Why

So that Header and Footer can be used outside of civicplatform.org
hackoregon/education-splash-page#9

When

ASAP, before Demo Day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant