Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to pass confidence level to summary? #17

Open
DominikRafacz opened this issue Jul 23, 2022 · 6 comments
Open

How to pass confidence level to summary? #17

DominikRafacz opened this issue Jul 23, 2022 · 6 comments
Labels
high-priority question Further information is requested restoration problems due to rewritting HaDeX gui

Comments

@DominikRafacz
Copy link
Contributor

The summary tab suggests that the table is universal between the plots, but the confidence level is taken from Comparison Plot in the original HaDeX. In HaDeX GUI temporally the fixed value is used. What shall be done?

@DominikRafacz DominikRafacz added question Further information is requested restoration problems due to rewritting HaDeX gui labels Jul 23, 2022
@michbur
Copy link
Member

michbur commented Jul 23, 2022

The assumption (in the manuscript proposing the summary table) is that the confidence level is global. @werpuc should we set the confidence level globally? I.e., manipulations of the confidence level at one plot affect all others?

@werpuc
Copy link
Member

werpuc commented Jul 25, 2022

Well, I'm lost here. Setting one global confidence level is against our assumptions - to let the user manipulate parameters and see how the data is changed. I've seen the users using this feature to see if setting the higher value is still working for them. Anyway, I'm against the global one, but have no idea how to choose a value for the summary table. Maybe the lowest for all chosen ones?

@michbur
Copy link
Member

michbur commented Jul 25, 2022

But does it make any sense to use one confidence level for one visualization and another confidence level for the other?

@DominikRafacz
Copy link
Contributor Author

Maybe shall we then readjust summary table somehow?

@michbur
Copy link
Member

michbur commented Jul 25, 2022

The summary table is well defined in the literature (10.1038/s41592-019-0459-y, supplementary table 1). But maybe we should put here information that the confidence interval is non-unified among different plots.

@werpuc
Copy link
Member

werpuc commented Jul 26, 2022

What about our previous approach - when we had two confidence levels in woods plot, we put both of them to the table. Maybe we can check all the confidence levels and show unique values in the table? even if there are three of them.
We don't know how people prepare the data for publication in hadex as no one is doing that. Guess we will learn by experience in the future (hopefully) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high-priority question Further information is requested restoration problems due to rewritting HaDeX gui
Projects
None yet
Development

No branches or pull requests

3 participants