-
Notifications
You must be signed in to change notification settings - Fork 12
Would be good to have some unittests #11
Comments
(Adding this because I'm about to send a pull request which includes tests :) |
By default KiCad doesn't use the Protel names, instead all the files end in `.gbr` and it uses 'B.Cu' and similar. (Fixes hadleyrich#12.) This also adds tests for both the KiCad and Protel file name format. (Part of hadleyrich#11.)
(Helps with hadleyrich#11.)
Maybe we could make that available as JSON and use the exact same data? |
For providing the whats-that-gerber test cases as JSON, we have a couple options:
What would be the easiest way for you guys to get and consume this JSON file? |
Either way works fine, we can just grab it directly over HTTP from where ever it is. If it stays where is is it might be a good idea to add a note that it's used externally so that fact doesn't get forgotten sometime in the future. |
I would suggest you use a URL pointing to a specific version, either through npmcdn or Github (or both?) https://npmcdn.com/[email protected]/test/filenames-by-cad.js With the npmcdn one you can also put in |
Whats-that-gerber 2.1.0 has been released with the test cases as JSON. I would suggest you use this source: https://npmcdn.com/whats-that-gerber@^2.1.0/test/filenames-by-cad.json |
The
guess_layer
function in gerber.py is pretty complicated, it would be nice to have some tests which check additions don't break existing use cases.The text was updated successfully, but these errors were encountered: