-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inclusion in F-Droid #37
Comments
No objection here. |
@IzzySoft is any progress on this? That would be really great |
I cannot tell, I'm currently not active at F-Droid. |
@yurtpage but you can add my repo to your F-Droid Client, where OpenWrtManager is listed. @hagaygo if you wish, you can pick a badge to link there from your Readme, so that Google one doesn't look so loneley 😉 |
@IzzySoft that's sad to hear. Maybe still you may help to create the app descriptor for inclusion? That would help to get the app to the store and attract more users and contributors. |
I can send a PR with the fastlane structures if @hagaygo wants it, they are set up at my end anyway. |
As far i can understand inclusion in F-Droid is awaiting donating ? |
@IzzySoft you already sent it, ty. We need the yaml file @hagaygo that's optionally, more like to filter out garbage |
No, that is not mandatory, it's rather a hint to the possibility.
Sorry, can't help you with that. I just run a binary repo, so I don't have all the build stuff in. The parts from my YAML that would be useful there are only these: Categories:
- Connectivity
License: GPL-3.0-only
AuthorName: Hagay Goshen
AuthorEmail: [email protected]
SourceCode: https://github.com/hagaygo/OpenWrtManager
IssueTracker: https://github.com/hagaygo/OpenWrtManager/issues
Changelog: https://github.com/hagaygo/OpenWrtManager/releases
AutoName: OpenWRT Manager
// here go the build details
AutoUpdateMode: Version
UpdateCheckMode: Tags |
Normally i use the latest stable one. 3.19 currently. |
@hagaygo Please join the discussion https://gitlab.com/fdroid/rfp/-/issues/2442#note_1886893631 |
great, but with 3.7.12 or 3.19.6, it fails to build: https://gitlab.com/fdroid/rfp/-/issues/2442#note_1886893631 |
The log start with missing files at this point :
It seems your build does not find the app files from some reason. |
yes, Linux is case sensitive, |
Might be the problem, i currently don't have access to a working flutter sdk environment for testing it on Linux and fixing the case sensitivity. The folder you mentioned might be the only problem , i guess its a by product of f59b8f8 |
maybe you can make a case sensitive search in logs |
You are welcome to fork and try until it works on the fork while testing it with @licaon-kter and then create a pull request. Currently i can test only on windows 🤷♂️ |
Hi , managed to setup a working linux development using docker
Got the same errors you mentioned and fixed the filename case on d585f99 Please try again. Thanks. |
@hagaygo builds fine reproducible builds ( https://f-droid.org/docs/Inclusion_How-To/#reproducible-builds ) are not possible since you build on windows and Flutter embeds its code paths ( https://f-droid.org/docs/Reproducible_Builds/#embedded-build-paths ) on macOS/Linux we can use the same path, but yours is for autopupdates we need a place to find the exact flutter version, eg. have Flutter as a git submodule that you use during builds too so it's always up to date, or at least have it written somewhere so we can grep it |
Hi Placing the whole flutter SDK (even as submodule) in the repo seems wrong. Adding a file called flutter.version in the repo root, which contains the flutter version is used ( 3.19.6 for example) would be enough ? |
Yes, just make sure to keep it up to date |
required for F-Droid builds. More info on #37
@licaon-kter just added the file , please let me know if you need anything else. |
Thank you!
23 июля 2024 г. 19:00:28 GMT+03:00, Licaon_Kter ***@***.***> пишет:
done: https://gitlab.com/fdroid/fdroiddata/-/commit/630344504218db4de351998385592e537eb661a0 🎉
--
Reply to this email directly or view it on GitHub:
#37 (comment)
You are receiving this because you were mentioned.
Message ID: ***@***.***>
Page
|
Thank you @licaon-kter @hagaygo |
Hello,
you already said you're not going to add the app in the F-Droid repository #12
F-Droid policy permits also to someone who isn't the author to propose the inclusion of an app, if the original author does not oppose.
So this issue is just to ask you if you are OK with me proposing the inclusion of your app in F-Droid.
The text was updated successfully, but these errors were encountered: