Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audio, audio/wav: Seek on a non-seekable source should return an error instead of panic #3040

Open
11 tasks
hajimehoshi opened this issue Jul 13, 2024 · 0 comments
Open
11 tasks

audio, audio/wav: Seek on a non-seekable source should return an error instead of panic #3040

hajimehoshi opened this issue Jul 13, 2024 · 0 comments
Labels
breaking-change
Milestone
v3.0.0

Comments

@hajimehoshi
Copy link
Owner

Operating System

  • Windows
  • macOS
  • Linux
  • FreeBSD
  • OpenBSD
  • Android
  • iOS
  • Nintendo Switch
  • PlayStation 5
  • Xbox
  • Web Browsers

What feature would you like to be added?

Now calling (*audio.Player).Seek with a non-seekable source panics, but this should return an error.

As this is a breaking change, we'll do it at v3.

Why is this needed?

No response
@hajimehoshi hajimehoshi added this to the v3.0.0 milestone Jul 13, 2024
@hajimehoshi hajimehoshi changed the title audio: Seek on a non-seekable source should return an error instead of panic audio, audio/wav: Seek on a non-seekable source should return an error instead of panic Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change
Projects
None yet
Milestone
v3.0.0
Development

No branches or pull requests
1 participant
@hajimehoshi