Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add TemplateFooterProcessor extension point for extending footer tag content in theme #6191

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add TemplateFooterProcessor extension point for extending footer tag content in theme #6191

wants to merge 1 commit into from
+199 −1

Conversation

guqing
Copy link
Member

@guqing guqing commented Jun 28, 2024

What type of PR is this?

/kind feature
/area core
/milestone 2.17.x

What this PR does / why we need it:

提供对模板中 halo footer 标签内容的扩展点以支持扩展页脚内容

Which issue(s) this PR fixes:

Fixes #6189

Does this PR introduce a user-facing change?

提供对模板中 halo footer 标签内容的扩展点以支持扩展页脚内容

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 28, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.17.x milestone Jun 28, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Jun 28, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and ruibaby June 28, 2024 03:38
@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jun 28, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from guqing. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov Codecov
Copy link

codecov bot commented Jun 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 57.03%. Comparing base (bc10336) to head (347358e).
Report is 27 commits behind head on main.

Files Patch % Lines
...eme/dialect/TemplateFooterElementTagProcessor.java 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #6191      +/-   ##
============================================
+ Coverage     54.51%   57.03%   +2.52%     
- Complexity     3523     3717     +194     
============================================
  Files           646      651       +5     
  Lines         21862    22052     +190     
  Branches       1528     1543      +15     
============================================
+ Hits          11917    12578     +661     
+ Misses         9328     8866     -462     
+ Partials        617      608       -9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ruibaby
ruibaby reviewed Jun 28, 2024
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2024
@ruibaby ruibaby added sig/docs Categorizes an issue or PR as relevant to SIG Docs. and removed lgtm Indicates that a PR is ready to be merged. labels Jun 28, 2024
@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jun 28, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruibaby ruibaby ruibaby left review comments

@JohnNiang JohnNiang Awaiting requested review from JohnNiang

Assignees

@ruibaby ruibaby

Labels
area/core Issues or PRs related to the Halo Core kind/feature Categorizes issue or PR as related to a new feature. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/docs Categorizes an issue or PR as relevant to SIG Docs.
Projects
None yet
Milestone
2.17.x
Development

Successfully merging this pull request may close these issues.

期望增加对主题端 footer 标签的内容扩展
2 participants
@guqing @ruibaby