Fix missing request argument after gql 4.0 upgrade (closes issue #172)#176
Open
harrymasson wants to merge 1 commit intohammem:mainfrom
Open
Fix missing request argument after gql 4.0 upgrade (closes issue #172)#176harrymasson wants to merge 1 commit intohammem:mainfrom
harrymasson wants to merge 1 commit intohammem:mainfrom
Conversation
|
@harrymasson - good work. @hammem I believe already fixed this in an issue but never released the new version with the fix. (Could be wrong on that though) Unfortunately, this library is quite active but @hammem has stopped responding or maintaining this repo at all. It's sad really. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replicated reported issue, fixed it, and updated unit tests to pass with fix in place. Also tested manually against actual monarch money API to verify fix works with real endpoints (script not included).
Here's a place in gql 4.0.0 release notes where they mention the breaking change causing this issue:
Note - I'm new to PRs on github / open source, please let me know if you need me to do anything else to help get this merged!