From ce1f2abf5aae40e3581510880d39a7153f9b9df7 Mon Sep 17 00:00:00 2001 From: Mohamed Akram Date: Wed, 20 Sep 2023 23:44:20 +0400 Subject: [PATCH] Drop support for EOL Node.js versions --- .github/workflows/ci.yml | 27 +-------------------- package.json | 2 +- tests/integration/multi-nodejs-test/test.sh | 2 +- 3 files changed, 3 insertions(+), 28 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2b9d4e46..cd0c1cfe 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -25,31 +25,6 @@ jobs: - name: Lint run: npm run lint - dependencies: - name: Test (dependencies) - runs-on: 'ubuntu-latest' - steps: - - name: Checkout - uses: actions/checkout@v2 - - - name: Setup Node.js - uses: actions/setup-node@v2 - with: - # Node 14 ships with npm v6, which doesn't install peer-dependencies by default. - # Starting with npm v7 (which is shipped with Node >= 16), peer-dependencies are - # automatically installed. So this test (check for unmet peer-dependencies) only - # works with Node <= 14. - node-version: '14' - - # Simulate an installation by a dependent package - - name: Install dependencies - run: | - rm package-lock.json - npm install --production - - - name: Check dependency tree - run: npm ls - test: name: Test (Node) runs-on: ${{ matrix.operating-system }} @@ -58,7 +33,7 @@ jobs: matrix: operating-system: ['ubuntu-latest', 'windows-latest'] # https://nodejs.org/en/about/releases/ - node-version: ['12', '14', '16', '18', '20'] + node-version: ['18', '20'] steps: - name: Checkout diff --git a/package.json b/package.json index 186b8093..815a694f 100644 --- a/package.json +++ b/package.json @@ -17,7 +17,7 @@ "license": "MIT", "readmeFilename": "README.markdown", "engines": { - "node": ">=12" + "node": ">=18" }, "dependencies": { "@handlebars/parser": "^2.1.0", diff --git a/tests/integration/multi-nodejs-test/test.sh b/tests/integration/multi-nodejs-test/test.sh index 67b0d28a..5dce414e 100755 --- a/tests/integration/multi-nodejs-test/test.sh +++ b/tests/integration/multi-nodejs-test/test.sh @@ -14,7 +14,7 @@ cd "$( dirname "$( readlink -f "$0" )" )" || exit 1 unset npm_config_prefix echo "Handlebars should be able to run in various versions of NodeJS" -for node_version_to_test in 12 14 16 18; do +for node_version_to_test in 18 20; do rm -rf target node_modules package-lock.json mkdir target