Change XSS header default to '0' #4352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinivy
added
feature
Closed
allbto-mck
added a commit
to allbto-mck/hapi
that referenced
this pull request
Dec 1, 2022
hapijs#4352 has changed the way xss behaves but the types were not updated yet.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for configuring the
x-xss-protectionsecurity header to0, and makes that the default in light of security issues that have been identified with XSS auditors/filters which are enabled by this header. This is also OWASP's recommendation, and it's widely employed by sites such as Facebook, Google, and this one (GitHub!).Resolves #4327