Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: suites must not use services build files directly #343

Open
ata-nas opened this issue Nov 14, 2024 · 0 comments
Open

refactor: suites must not use services build files directly #343

ata-nas opened this issue Nov 14, 2024 · 0 comments
Labels
Improvement Code changes driven by non business requirements
Milestone

Comments

@ata-nas
Copy link
Contributor

ata-nas commented Nov 14, 2024

What Happened

Based on this comment thread we must not use :service related build files directly in :suites, be that runtime or during build. Although the :suite relies on the :server, we must isolate both projects better.

What Should Happen

  • see this comment thread
  • generally it is best practice to use gradle to copy all needed build/environment related resources to local subproject build folder and run tasks from there
  • projects must not use build/environment related resources of other projects directly, be that in the build process or in code
  • projects must be isolated and the build process must be isolated and deterministic, we should not go out of the respective project's build root when building, supplying all needed resources there using gradle
@ata-nas ata-nas added the Improvement Code changes driven by non business requirements label Nov 14, 2024
@ata-nas ata-nas added this to the 0.3.0 milestone Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Code changes driven by non business requirements
Projects
None yet
Development

No branches or pull requests

1 participant