Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change the liveRootPath and archiveRootPath to absolute paths as default #371

Open
5 tasks
Tracked by #309
ata-nas opened this issue Nov 28, 2024 · 1 comment
Open
5 tasks
Tracked by #309
Assignees
Labels
Block Node Issues/PR related to the Block Node. Improvement Code changes driven by non business requirements P2 Required to be completed in the assigned milestone, but may or may not impact release schedule.
Milestone

Comments

@ata-nas
Copy link
Contributor

ata-nas commented Nov 28, 2024

Description

What Needs to be Done

  • create a basePath configuration with default value /opt/hashgraph/blocknode/data/
  • liveRootPath must be resolved from the basePath with default value live/
  • archiveRootPath must be resolved from the basePath with default value archive/
  • migrate from String type configs to Path type configs
  • simplify/remove preconditions and path resolution logic in constructor
@ata-nas ata-nas self-assigned this Nov 28, 2024
@ata-nas ata-nas added Improvement Code changes driven by non business requirements P2 Required to be completed in the assigned milestone, but may or may not impact release schedule. Block Node Issues/PR related to the Block Node. labels Nov 28, 2024
@ata-nas ata-nas added this to the 0.3.0 milestone Nov 28, 2024
@jsync-swirlds
Copy link
Member

Perhaps, rather than setting absolute paths for each entry, create a configuration for "blockNode.filesystem.basePath" set to /opt/hashgraph/blocknode/data and then the two storage paths can be relative to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Block Node Issues/PR related to the Block Node. Improvement Code changes driven by non business requirements P2 Required to be completed in the assigned milestone, but may or may not impact release schedule.
Projects
None yet
Development

No branches or pull requests

2 participants