Skip to content

Commit

Permalink
chore: resolve comments
Browse files Browse the repository at this point in the history
Signed-off-by: nikolay <[email protected]>
  • Loading branch information
natanasow committed Nov 22, 2024
1 parent 4fb93a5 commit d669b9b
Show file tree
Hide file tree
Showing 5 changed files with 33 additions and 27 deletions.
48 changes: 24 additions & 24 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/relay/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"dependencies": {
"@hashgraph/json-rpc-config-service": "file:../config-service",
"@ethersproject/asm": "^5.7.0",
"@hashgraph/sdk": "^2.53.0",
"@hashgraph/sdk": "^2.54.0-beta.1",
"@keyvhq/core": "^1.6.9",
"axios": "^1.4.0",
"axios-retry": "^3.5.1",
Expand Down
6 changes: 6 additions & 0 deletions packages/relay/src/lib/clients/sdkClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -818,6 +818,12 @@ export class SDKClient {
`${requestDetails.formattedRequestId} Successfully execute all ${transactionResponses.length} ${txConstructorName} transactions: callerName=${callerName}, status=${Status.Success}(${Status.Success._code})`,
);
} catch (e: any) {
// Log the target node account ID, right now, it's populated only for MaxAttemptsOrTimeout error
if (e?.nodeAccountId) {
this.logger.info(

Check warning on line 823 in packages/relay/src/lib/clients/sdkClient.ts

View check run for this annotation

Codecov / codecov/patch

packages/relay/src/lib/clients/sdkClient.ts#L823

Added line #L823 was not covered by tests
`${requestDetails.formattedRequestId} Transaction failed to execute against node with id: ${e.nodeAccountId}`
);
}
const sdkClientError = new SDKClientError(e, e.message);

this.logger.warn(
Expand Down
2 changes: 1 addition & 1 deletion packages/server/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"uuid": "^3.3.2"
},
"devDependencies": {
"@hashgraph/sdk": "^2.53.0",
"@hashgraph/sdk": "^2.54.0-beta.1",
"@koa/cors": "^5.0.0",
"@types/chai": "^4.3.0",
"@types/cors": "^2.8.12",
Expand Down
2 changes: 1 addition & 1 deletion packages/ws-server/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"pino-pretty": "^7.6.1"
},
"devDependencies": {
"@hashgraph/sdk": "^2.53.0",
"@hashgraph/sdk": "^2.54.0-beta.1",
"@koa/cors": "^5.0.0",
"@types/chai": "^4.3.0",
"@types/cors": "^2.8.12",
Expand Down

0 comments on commit d669b9b

Please sign in to comment.