Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Workflow tests.yaml fails silently on codecov upload failures #3287

Closed
rbarker-dev opened this issue Nov 21, 2024 · 0 comments · Fixed by #3299
Closed

CI Workflow tests.yaml fails silently on codecov upload failures #3287

rbarker-dev opened this issue Nov 21, 2024 · 0 comments · Fixed by #3299
Assignees
@san-est @PavelSBorisov @mishomihov00
Labels
bug Something isn't working github_action
Milestone
0.62.0

Comments

@rbarker-dev
Copy link
Contributor

Description

Codecov uploads fail with a status code of 0 from the codecov-upload.sh script. CI status is set to passing even when failures occur.

Recommend adding -Z flag to retrieve the non-zero exit code from codecov

Steps to reproduce

Run tests.yaml

Additional context

image

Hedera network

other

Version

main

Operating system

None
@rbarker-dev rbarker-dev added the bug Something isn't working label Nov 21, 2024
@rbarker-dev rbarker-dev added this to the 0.62.0 milestone Nov 21, 2024
@mishomihov00 mishomihov00 linked a pull request Nov 26, 2024 that will close this issue
ci: Pass CODECOV_TOKEN to acceptance workflow #3299
Merged
2 tasks
@mishomihov00 mishomihov00 mentioned this issue Nov 26, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@san-est san-est

@PavelSBorisov PavelSBorisov

@mishomihov00 mishomihov00

Labels
bug Something isn't working github_action
Projects
None yet
Milestone
0.62.0
Development

Successfully merging a pull request may close this issue.

ci: Pass CODECOV_TOKEN to acceptance workflow hashgraph/hedera-json-rpc-relay
4 participants
@san-est @PavelSBorisov @rbarker-dev @mishomihov00