fix: improves getContractAddressFromReceipt

[konstantinabl]

Description:

Changes

Changed method getContractAddressFromReceipt to align with design doc and be more clear

Technical Details

The reason we substring the last 40 characters is the fact that the last 20 bytes are the returned tokenAddress as a response

Related issue(s):

Fixes #3322

Checklist

• Documented (Code comments, README, etc.)
• Tested (unit, integration, etc.)

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Test Results

 21 files  ± 0  289 suites  +5   47m 28s ⏱️ + 4m 33s
612 tests ± 0  605 ✅ + 2  4 💤 ±0  3 ❌  - 2 
807 runs   - 63  797 ✅  - 62  7 💤 +2  3 ❌  - 3 

For more details on these failures, see this check.

Results for commit 55879d6. ± Comparison against base commit 28f9b33.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.

"before each" hook for "should execute "eth_getStorageAt" request to get current state changes" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-2 RPC Server Acceptance Tests "before each" hook for "should execute "eth_getStorageAt" request to get current state changes"

"before all" hook in "Debug API Test Suite" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests Debug API Test Suite "before all" hook in "Debug API Test Suite"

♻️ This comment has been updated with latest results.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.00%. Comparing base (28f9b33) to head (55879d6).
Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3323      +/-   ##
==========================================
+ Coverage   84.94%   85.00%   +0.06%     
==========================================
  Files          69       69              
  Lines        4655     4655              
  Branches     1042     1042              
==========================================
+ Hits         3954     3957       +3     
+ Misses        400      394       -6     
- Partials      301      304       +3     

Flag	Coverage Δ
config-service	98.14% <ø> (ø)
relay	78.75% <0.00%> (ø)
server	83.28% <ø> (ø)
ws-server	36.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
packages/relay/src/lib/eth.ts	86.35% <100.00%> (+0.53%)	⬆️

... and 1 file with indirect coverage changes